search

alexeyzimarev / MassTransit.EventStoreIntegration

EventStore persistence for MassTransit
Apache License 2.0
49 stars 14 forks source link

System.TypeLoadException: Method 'SendQuery' in type 'MassTransit.EventStoreIntegration.Saga.EventStoreSagaRepository`1' from assembly 'MassTransit.EventStoreIntegration, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation. #7

Open PatriceMarin opened 4 years ago

PatriceMarin commented 4 years ago

Hi Alexey,

I'm working on a project which required saga features. The Sample-Courier provided by MassTransit describes everything I need, except the storing part.

So I'm writing a POC to be more familiar with Routing Slip pattern and so on...based on Sample-Courier and your MassTransit.EventStoreIntegration to store the saga state in EventStore.

When I start the SagaStateMachine host, I've got the following error: "System.TypeLoadException: Method 'SendQuery' in type 'MassTransit.EventStoreIntegration.Saga.EventStoreSagaRepository`1' from assembly 'MassTransit.EventStoreIntegration, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation."

I noticed the Task SendQuery<T> method throw: NotImplementedByDesignException("Redis saga repository does not support queries");

Can you explain me why this method is not implemented?

I hope it's clear enough...

Thanks for your help.

PatriceMarin commented 4 years ago

Hi,

It seems the new version of MassTransit has some breaking changes on the ISagaRepository<TSaga> interface.

alexeyzimarev commented 4 years ago

It's because EventStore doesn't have queries. It is the same for all persistence providers that can only fetch entities by key, like Redis: https://masstransit-project.com/usage/sagas/redis.html

PatriceMarin commented 4 years ago

The reason I got this exception is MassTransit.EventstoreIntegration is not compatible with the latest version of MassTransit (v6.2.0).

MassTransit has updated the signature of the SendQuery method of the ISagaRepository interface.

I've made the changes locally and I'm now able to run the host.

Do you think you will be able to apply the changes? Otherwise, I could contribute to the project via a PR?

Just let me know.

Thanks

alexeyzimarev commented 4 years ago

a PR would be great :)

PatriceMarin commented 4 years ago

I do not have permissions to push my branch on the repository.

alexeyzimarev commented 4 years ago

PRa are done from personal forks. Check the GH docs.

On Fri, 13 Mar 2020 at 19:20, Patrice Marin notifications@github.com wrote:

I do not have permissions to push my branch on the repository.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alexeyzimarev/MassTransit.EventStoreIntegration/issues/7#issuecomment-598853960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVQYVICUCOYJI46WUG7WYLRHJ2ORANCNFSM4LG7OH3A .

PatriceMarin commented 4 years ago

Hi Alexey, My PR does not build. It seems the final step, unit tests, failed after 6 hours. I don't know why. I've run the tests on my laptop....everything works fine.

Any clue?