search

alexf2015 / openhab-addons

Add-ons for openHAB 2.x
Eclipse Public License 2.0
7 stars 5 forks source link

Hot water mode: Smart control #2

Closed yozik04 closed 5 years ago

yozik04 commented 5 years ago

For F1x55 Nibe has added new Hot water mode with recent firmware update. Mode is called "Smart control". It automatically adapts hot water production according to your consumption during the day. Manual says it uses previous week's data.

To be merged after #1 pull request.

yozik04 commented 5 years ago

@alexf2015 Do you plan to merge this as well?

alexf2015 commented 5 years ago

Hi, I could include this but currently your Pull-Requests looks weird. It contains many commits that where somehow duplicated from my branch. Could you please rebase once again on my nibeuplink-dev branch.

You should only pick commits that belong to your PR and skip all others.

Thanks

yozik04 commented 5 years ago

I am closing this pull request. Will open another one to core openhab2-addons directly.

But I have question to you. F1255 has additional option on 47041 channel. <option value="4">Smart control</option>

Where should I add this option? base-channel-types.xml or I need to create block in f1155-channel-types.xml?