alexferl / vyper

Python configuration with (more) fangs
MIT License
144 stars 21 forks source link

Do not use `logging.basicConfig` #10

Closed jperkelens closed 6 years ago

jperkelens commented 6 years ago

this sets a handler on the root logging handler and will not let consumers set their own config. instead call setLevel on the logger returned from getLogger()

alexferl commented 6 years ago

Agreed. I didn't notice it because of my logging setup in my apps I guess, so good catch! I'll just remove logging.basicConfig and let people manage the log level themselves which seems to be how most libraries do it which is why I personally have stuff like logging.getLogger('requests').setLevel(logging.WARN) in my apps.