search

alexferl / vyper

Python configuration with (more) fangs
MIT License
144 stars 21 forks source link

Fixes case insensitive complex env binding #12

Closed jperkelens closed 6 years ago

jperkelens commented 6 years ago

Hi! Sorry you've been getting so much activity from me, would have really liked to get this all in one PR. However, didn't think to look into this till after I discovered the insensitivity issue. This PR:

a) Allows for multiple env bindings deep in a complex binding where they share the same root. i.e.:

v.bind_env('icings.regular', 'ICINGS_REGULAR')
v.bind_env('icings.premium', 'ICINGS_PREMIUM')

and

b) Respects the case insensitivity of env binding while keeping key casing the same no matter what level of the config you pull.

alexferl commented 6 years ago

No worries. Thanks for them! I made a change request with two very simple changes before I can merge it.

jperkelens commented 6 years ago

done!