search

alexfernandez / loadtest

Runs a load test on the selected URL. Fast and easy to use. Can be integrated in your own workflow using the API.
MIT License
2.58k stars 210 forks source link

Callback function is not called by anyone, possible dead code #218

Closed damianpumar closed 1 year ago

damianpumar commented 1 year ago

I am creating a load test, and I am trying to see the results of a specific request and I cannot. I think the callback function is not being used. In that case, I can fix it.

https://github.com/alexfernandez/loadtest/blob/main/lib/loadtest.js#L101-L114

alexfernandez commented 1 year ago

I am investigating the issue. You are right, it needs to be restored, but I will have to change the interface and remove the latency parameter because it would slow it down too much. I hope it's OK!

alexfernandez commented 1 year ago

Fixed in https://github.com/alexfernandez/loadtest/pull/220, beware because the interface has changed to statusCallback(error, result).

Released as v7.0.0.