search

alexfertel / bulloak

A Solidity test generator based on the Branching Tree Technique.
Apache License 2.0
225 stars 13 forks source link

Commit Cargo.lock file #48

Closed beeb closed 7 months ago

beeb commented 7 months ago

I would be nice to commit your Cargo.lock file, as suggested by the Cargo team. This also would help with creating a nix derivation for this utility, which requires a Cargo.lock file for reproducibility.

alexfertel commented 7 months ago

Yes! I remember reading that but forgot to do it. Thanks for opening this issue 👍🏻

beeb commented 7 months ago

I would be happy to publish the package to the nixpkgs repo once that is done! It would be also very useful to tag versions in git with v0.x.x tags.

alexfertel commented 7 months ago

It would be also very useful to tag versions in git with v0.x.x tags.

I had been doing that, but was also forgetting to push the tags 🤦🏻‍♂️ Pushed both the tags and the Cargo.lock just now. Thanks for pointing that out!

I would be happy to publish the package to the nixpkgs repo once that is done!

That would be very awesome 🙏🏻

alexfertel commented 7 months ago

Closing since https://github.com/alexfertel/bulloak/commit/ac4fe7d4a94dcc249f359451ff05d0a05fdc2ac5 resolves this.

beeb commented 7 months ago

Awesome! Feel free to ping me on the next release so that I can make a nix derivation (currently there is no existing version with a lock file).

alexfertel commented 7 months ago

Hey @beeb, I published a new version! v0.5.4 includes the Cargo.lock. However, I wanted to check with you one thing. Currently, I change the package version in the commit right after I add a tag, i.e. I end up with the following: Screenshot 2023-11-16 at 17 50 38

where, chore(v0.5.4) is the commit updating the package version, which in turn updates the Cargo.lock and fix(scaffold) is the tag v0.5.4.

Would that be an issue for the nix derivation? If yes, I'll figure out how to do everything at once (currently doing this because I'm using git-cliff to generate the changelogs).

beeb commented 7 months ago

Thanks for the quick release! Yeah the way you are doing it is indeed a problem. If I check out the tag I will not see the correct information in the Cargo files. It would be no problem if the tag came after the changes in Cargo files (as long as they didn't change in the mean time) but it's a problem if the tag is before.

alexfertel commented 7 months ago

Hmmm, I see. Okay, I force-pushed (should be fine, since it's been live for just an hour) the tag to point to the correct commit and will figure out a new flow for the next release. Lmk if it works well for you this way.

beeb commented 7 months ago

There you go https://github.com/NixOS/nixpkgs/pull/268113