Closed drgorillamd closed 2 months ago
@alexfertel I'm opening this so you can take a quick look (I changed a bit the idea/added an optional toml for this kind of optional setup). Let me know what you think and I'll add docs/natspecs afterward, in the meantime, I'll replace the StringLiteral by the correct solang expression in the sol translator
Yo! If you need any help or anything at all lmk, quite excited about this getting merged!
hmm, one small extra thingy to add: we now need forge-std as an import (but I guess it's not too opiniated to add it when a cheatcode is being inlined too, right @alexfertel ?)
we now need forge-std as an import (but I guess it's not too opiniated to add it when a cheatcode is being inlined too, right @alexfertel ?)
Yup, it's fine to do so since we are tied to foundry anyway for now.
It should be well-documented both in doc comments and the README.
Attention: Patch coverage is 99.25651%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 93.2%. Comparing base (
4c2002d
) to head (dda4d18
). Report is 2 commits behind head on main.
Add a vm.skip(true); at the beginning of each function (closes #57)
Without this forge cheatcode, tests are being run and show as "Pass", even when empty (false positive). With this cheatcode, they would show as "Skipped"
Implementation
A new node is added in the hir tree itself, after reading an optional bulloak.toml (which should contain a
no_skip
bool, set to true if this cheatcode should not be included in the final test)