alexfertel / bulloak

A Solidity test generator based on the Branching Tree Technique.
Apache License 2.0
225 stars 13 forks source link

Refactor: create a cfg struct to inject dep #64

Closed drgorillamd closed 4 weeks ago

drgorillamd commented 2 months ago

Right now, arg parsed with clap are passed as individual values to the relevant fn, as there are only 4 of them for scaffold (w, f, s and S) and 2 for check.

As more option are introduced, an ever-growing list of function parameters isn't sustainable and should rather be part of a struct (leaving the cli arg versus Bulloak.toml discussion for #38 ).

let scaffolder = Scaffolder::new(&self.solidity_version, &self.with_vm_skip);

would become

let scaffolder = Scaffolder::new(&self.cfg);
alexfertel commented 4 weeks ago

Resolved by https://github.com/alexfertel/bulloak/pull/67 (forgot to mention the issue in the PR description)

alexfertel commented 4 weeks ago

I'll tackle #38 next probably