issue #19 - check for corrupted/invalid files

alexgand / springer_free_books

Python script to download all Springer books released for free during the 2020 COVID-19 quarantine

GNU General Public License v3.0

1.64k stars 366 forks source link

issue #19 - check for corrupted/invalid files #27

Closed pjungermann closed 4 years ago

pjungermann commented 4 years ago

check whether PDFs are valid using PyPDF2
check whether ePubs (=Zips) are valid using zipfile
try 3 times and then give up and continue
- print error information
- can be recovered/tried again by running the downloader again

pjungermann commented 4 years ago

caveat: those additional checks will make the downloader slower

martinbra commented 4 years ago

Hey @pjungermann, very nice idea of yours. There could be an option like "python main.py --validate-at-end" to validate files after all the downloads are completed, in order to not make the downloader slower.

pjungermann commented 4 years ago

@martinbra yes, this could be done. It would not be so easy to retry then, but as this script is able to cover this with a re-run, might be alright.

Not sure if @alexgand wants any of those options merged though.

alexgand commented 4 years ago

Folks, for the sake of simplicity I'll leave the code as it is. Thanks, though.