search

alexgand / springer_free_books

Python script to download all Springer books released for free during the 2020 COVID-19 quarantine
GNU General Public License v3.0
1.64k stars 366 forks source link

Added code to limit the maximum filename length #79

Closed chaosAD closed 4 years ago

chaosAD commented 4 years ago

A filename cannot exceed a certain maximum length. Error will be thrown if it is breached. The max length imposed by the OS is computed from the full path of the file. This means, the maximum length for a bookname changes according to which directory it is stored. In the script, the limit is set to either 145 or the max length determined on-the-fly, whichever is smaller. This will solve #72.

alexgand commented 4 years ago

I had to revert this PR, on my windows machine it stoped working.

chaosAD commented 4 years ago

Can you elaborate further because it works fine on my machine?

alexgand commented 4 years ago

image

chaosAD commented 4 years ago

Oh! ok. Can you try this commit? Hopefully, I have fixed it.

alexgand commented 4 years ago

Tried, another error: image

chaosAD commented 4 years ago

Fixed those problems in my latest commit.

alexgand commented 4 years ago

Still don't work here: image

chaosAD commented 4 years ago

Okay. I fixed once and for all and tested those functions on Python 3.8.1; finally. Sorry. for the trouble.

I have pushed the new commit to my repository. Can you try it once more?

alexgand commented 4 years ago

Now it works!

chaosAD commented 4 years ago

Hi Alex,

Actually there is one pending PR by ghost. He somehow did a pull request on my behalf for some reason I am not sure. So now I can't create any further pull requests because of that. Could you please either accept that pull request or dismiss it?

Thanks.

rgds, chaosAD

From: Alexandre Gandini notifications@github.com Sent: 03 May 2020 09:53 To: alexgand/springer_free_books springer_free_books@noreply.github.com Cc: e13ktr0k!ut - zap frasker@hotmail.com; Author author@noreply.github.com Subject: Re: [alexgand/springer_free_books] Added code to limit the maximum filename length (#79)

Now it works!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/alexgand/springer_free_books/pull/79#issuecomment-623084025, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAUZUWGF6GXZ3I5Y4USTRJTRPU5JHANCNFSM4MXELI3A.

alexgand commented 4 years ago

Thanks @chaosAD, I approved and merged the PR.