alexgarces / react-typeform-embed

React wrapper for Typeform Embed SDK
https://alexgarces.github.io/react-typeform-embed/
MIT License
124 stars 35 forks source link

Update dependency constraints #18

Closed phlipper closed 5 years ago

phlipper commented 6 years ago

Overview

This PR updates the dependency constraints to make updates more flexible for library users.

Move react and react-dom to peerDependencies:

peerDependencies specifies which versions your reusable component supports/requires.

Putting react in dependencies can cause multiple versions of React to be installed if somebody uses your component but has a different version of React in their own package.json.

Move react-scripts to devDependencies:

The react-scripts package contains development tools and dependencies which are not required by the library consumer and can cause version conflicts.

Notes

caaatisgood commented 6 years ago

oh wow, learned a lot from the description! thanks @phlipper!

alexgarces commented 5 years ago

This is awesome @phlipper, I also learned a lot! I added the PR to the next version. Thanks a lot!