alexgaribay / sendgrid_elixir

Create and send composable emails with Elixir and SendGrid.
MIT License
86 stars 44 forks source link

Implements add_dynamic_template_data/2 #29

Closed kawikadkekahuna closed 5 years ago

kawikadkekahuna commented 5 years ago

Per the v3 API Documentation, it seems that the "dynamic_template_data" field must exist on the personalizations key.

Adds dynamic_template_data to the whitelist of keys that are mapped to personalizations.

alexgaribay commented 5 years ago

Thanks for the PR.

~After looking at the SendGrid Docs, it looks like the dynamic_template_data key must exist under a personalization object which isn't currently part of the lib. #27 adds support for it. Once that is in, you'll need to add it to the personalization API.~

kawikadkekahuna commented 5 years ago

I appreciate the response! I've made the requested changes. Let me know if anything else is needed.

alexgaribay commented 5 years ago

👍 🎉