Fix issue #292 - Githubissues

alexgolec / tda-api

A TD Ameritrade API client for Python. Includes historical data for equities and ETFs, options chains, streaming order book data, complex order construction, and more.

https://tda-api.readthedocs.io

MIT License

1.26k stars 335 forks source link

Fix issue #292 #294

Closed ashwinrajesh8 closed 2 years ago

ashwinrajesh8 commented 2 years ago

Resolving Issue #292
Added support for need_extended_hours_data within the time interval shortcut functions.
Default state of need_extended_hours_data set to True

Co-Authored-By: Ashwin Rajesh ashwin.rajesh@gmail.com

alexgolec commented 2 years ago

Please add tests

alexgolec commented 2 years ago

Note this change breaks tests.

ashwinrajesh8 commented 2 years ago

Going through error logs indicated that most of the failed test cases were due to the absence of needExtendedHoursData in params, example below: Adding this parameter to the tests should patch 42 of 56 failed cases, the remaining 14 have to do with the no_extendedhours tests.

alexgolec commented 2 years ago

Sounds good, please ping the review when the tests are fixed

alexgolec commented 2 years ago

LGTM, merging. Thanks for the PR!