search

alexgolec / tda-api

A TD Ameritrade API client for Python. Includes historical data for equities and ETFs, options chains, streaming order book data, complex order construction, and more.
https://tda-api.readthedocs.io
MIT License
1.26k stars 338 forks source link

Separate out Enums #297

Open bhatiarohan01 opened 2 years ago

bhatiarohan01 commented 2 years ago

Is your feature request related to a problem? Please describe. It will be much cleaner and helpful if we can separate out the enum classes from the BaseClient class. The benefits are 1\ much cleaner code when you make the function call. 2\ SOC. 3\ when building wrappers client object can be hidden, otherwise always have to create hooks to expose the client.

Describe the solution you'd like Separate out Enums in a different file and import it.

Describe alternatives you've considered None Additional context I have done the separation in my local environment and tested that client. I can contribute if you think this is reasonable.

pssolanki111 commented 2 years ago

+1

@bhatiarohan01 I'd be interested in the idea. Please share the local structure you have.