search

alexgolec / tda-api

A TD Ameritrade API client for Python. Includes historical data for equities and ETFs, options chains, streaming order book data, complex order construction, and more.
https://tda-api.readthedocs.io
MIT License
1.26k stars 335 forks source link

Update docs around advanced orders and OCO/trigger #302

Closed alexgolec closed 2 years ago

alexgolec commented 2 years ago

Apparently composite orders no longer require Advanced Features to be disabled

codecov[bot] commented 2 years ago

Codecov Report

Merging #302 (8c2d4cb) into master (1922c54) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          19       19           
  Lines        2193     2193           
  Branches      306      306           
=======================================
  Hits         2184     2184           
  Misses          4        4           
  Partials        5        5
Flag Coverage Δ
unittests 99.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1922c54...8c2d4cb. Read the comment docs.

s-maheshbabu commented 2 years ago

There is this statement here.

This will also preclude you from placing complex orders, like 1 TRG OCO.

Should we remove that statement or make it less assertive?

alexgolec commented 2 years ago

I'm confused, that's a link to a different project

s-maheshbabu commented 2 years ago

Oops, I mixed up things. I'm working with the other repo too and confused things :) Sorry about that. Your current PR lgtm.