Import of crc using es6 syntax results in an undefined import after bundling with webpack

alexgorbatchev / crc

Blazingly fast CRC implementations for node.js and browser

MIT License

349 stars 72 forks source link

Import of crc using es6 syntax results in an undefined import after bundling with webpack #55

Closed fullykubed closed 6 years ago

fullykubed commented 6 years ago

Ran into this issue while bundling the stellar-sdk library. I posted an issue about it with more details here: https://github.com/stellar/js-stellar-base/issues/136

fullykubed commented 6 years ago

I want to say it is related to commit 0cd7c6305328b3fb8bb9d20954ecaa943f43ba3e, but :man_shrugging:

alexgorbatchev commented 6 years ago

@jclangst I wasn't able to reproduce the webpack issue. I've added a webpack test to the project, maybe you could try to modify it to bring it to a failing state?

fullykubed commented 6 years ago

So it looks like in the old build one was able to attach the whole module to an object via import crc from 'crc'. Looks like that is no longer the case in 3.6.0.

alexgorbatchev commented 6 years ago

fixed