search

alexgorbatchev / crc

Blazingly fast CRC implementations for node.js and browser
MIT License
349 stars 72 forks source link

Edits webpack test to cause failure in version 3.6.0 #56

Closed fullykubed closed 6 years ago

fullykubed commented 6 years ago

So below are the edits that will cause the webpack failure. This import method worked in the previous version (as shown in https://github.com/stellar/js-stellar-base/blob/master/src/strkey.js) but now it results in an undefined object.

fullykubed commented 6 years ago

Related to #55

alexgorbatchev commented 6 years ago

Can you tell me if e39d4cdff0877e252835f3b876df18ba3c5ee8c5 fixes the issue for you?

Also, I do recommend using direct import, it should give you smaller bundle size.

import { crc32 } from 'crc/crc32';
alexgorbatchev commented 6 years ago

ping!