search

alexguan / node-zookeeper-client

A pure Javascript ZooKeeper client for Node.js
Other
540 stars 147 forks source link

Add removeRecursive and listSubTreeBFS methods #88

Closed lambertkuang closed 5 years ago

lambertkuang commented 5 years ago

Add methods removeAll and getAllChildren. Implementation is based off the java ZKUtil class.

Related issues: https://github.com/alexguan/node-zookeeper-client/issues/54, https://github.com/alexguan/node-zookeeper-client/issues/10

alexguan commented 5 years ago

When it's ready to be reviewed, please squash your commit

lambertkuang commented 5 years ago

It's ready for review, thanks!

lambertkuang commented 5 years ago

Hey @alexguan, please review this when you get a chance

ghostg00 commented 5 years ago

When to merge

alexguan commented 5 years ago

Overall this is a good PR, however does it belong the core zookeeper client though? It's more like an util that should exist outside the client.

lambertkuang commented 5 years ago

It would be nice to have in this library so people don't have to implement or require a separate util to have this functionality. I see that mkdirp is also included in this library, which seems in line with these two methods.