alexguirre / RAGENativeUI

MIT License
117 stars 37 forks source link

Pause menu enhancements #141

Closed pnwparksfan closed 2 years ago

pnwparksfan commented 2 years ago

Several improvements to TabMissionSelectItem:

Improvements to TabSubmenuItem:

thatmaxplayle commented 2 years ago

As per PNWParksFan's request, I'm leaving this screenshot in the discussion for this PR.

  1. Having some weird issue with dynamic tab widths since using a binary with these enhancements.
  2. The text doesn't look brilliant when long strings are used. I don't think this is specific to this PR, more of an issue in general. But I have not tested it with the older version, so who knows... a dynamic title height (as PNW suggested) or maybe a dynamic text size for the title string?

image

pnwparksfan commented 2 years ago

@alexguirre do you think there should be different formatting for background color and foreground color on skipped items (in menus or tabs), like there is for disabled items on menus? And if so, should that formatting apply automatically or be optional? I added some default formatting to gray out skipped tabs in a TabView, but noticed that in a UIMenu a Skipped element isn't formatted different currently. It might be confusing to users to have a tab or menu item they can't select with no visual indicator.

271590_20220312001658_1

pnwparksfan commented 2 years ago

As per PNWParksFan's request, I'm leaving this screenshot in the discussion for this PR.

  1. Having some weird issue with dynamic tab widths since using a binary with these enhancements.
  2. The text doesn't look brilliant when long strings are used. I don't think this is specific to this PR, more of an issue in general. But I have not tested it with the older version, so who knows... a dynamic title height (as PNW suggested) or maybe a dynamic text size for the title string?

image

Item 2 resolved with d3976e3