search

alexguirre / RAGENativeUI

MIT License
115 stars 38 forks source link

Potenetial fix for a TabSubMenu/TabInteractivelist issue #91

Closed oliverpope03 closed 4 years ago

oliverpope03 commented 4 years ago

Fixes #90.

alexguirre commented 4 years ago

Looks good, I don't really like making special cases for specific items but doing it some other way would require some refactoring.

oliverpope03 commented 4 years ago

Yeah thats why i suggested it, thank you for showing me that trick with the "is" thatll optimize alot of my code as well, i wasnt sure how you would sort it but it seemed like a submenu specfic bug

alexguirre commented 4 years ago

Probably making the Focused or Visible properties virtual and overriding them on TabSubmenuItem to unfocus its items. But yeah, not planning on refactoring pause menus much on 1.7.

Anyways, thanks for the pull request.