Skippable UIMenuItem Bool

oliverpope03 commented 4 years ago

Video.zip

alexguirre commented 4 years ago

I haven't tested it yet because of the update, but there are a few issues that come to mind:

After adding items to a menu, if the first item has Skipped = true when opening the menu it will selected. Maybe UIMenu.RefreshIndex() should take Skipped into account?
If all items are Skipped = true, it will cause an infinite loop when moving up/down. Maybe UIMenu.CurrentSelection should be allowed to be -1 to indicate that there is no selected item (this is already the case when the number of items is 0), so if all items are skipped it can be set to -1.

Not sure if we should bother fixing those cases, or just document that they are not supported.

oliverpope03 commented 4 years ago

For the first case i think i should definitely fix something up to do with that, as thats seems like a high likelihood case.

However the second one we could look in to but it would be minor enough to document if needed in my opinion, if a menu is fully skipped, the only use would be an information menu in theory, and a work around devs could do is having a "title" text item to be selected when the information is below it.

Edit: After having a tiny think about it i have two potential ways of sorting these, which could work which i can discuss with you on discord if you want?

alexguirre commented 4 years ago

Sure

alexguirre / RAGENativeUI

Skippable UIMenuItem Bool #94