alexhartm / tonie-podcast-sync

allows synching podcast episodes to Toniebox creative tonies
https://pypi.org/project/tonie-podcast-sync/
MIT License
27 stars 5 forks source link

feat: Store Settings and CLI #24

Closed Wilhelmsson177 closed 8 months ago

Wilhelmsson177 commented 9 months ago

Hello @alexhartm and @maltebaer

I have written a feature to store the data you want to write to all of your Tonies. The settings will be persisted in a TOML file, which is also really easy to edit and may also lower the barrier for people, who do not know how to write Python scripts. To get an even easier start, I have also added a CLI to set up the files and update the Tonies bases on the settings files.

To structure all the scripts and declutter, I have moved the python modules into a subdirectory.

If you like the idea and approach, leave a comment. Before merging, I would like to update the docs, but wanted to get your feedback first.

P.S.: The idea and feature itself was already a few months old, so the latest changes from you had to be merged into my long living branch. I hopefully did not forget anything.

alexhartm commented 9 months ago

This is an excellent idea @Wilhelmsson177 ! I also think that it would greatly help new users. In fact, I was thinking of adding something similar, but could not find the time to work on it so far. I'll have a deeper look and try it out in the next days. But on a first glance, it looks really awesome!

maltebaer commented 9 months ago

this is awesome! currently i do this kind of stuff (select tonie, podcast, settings, ...) in a script. having it as a native feature sounds really helpful.

how can i test/use the cli locally? i have checked out your repo but i'm not sure how to proceed from there on.

alexhartm commented 9 months ago

@maltebaer if you have the repo from @Wilhelmsson177 cloned locally, here is how I did it:

Note that this requires having poetry installed. But as far as I remember, that's all that is required...

btw, you could also use a github codespace for this if you don't want to do it on your machine. The codespace even installs poetry for you automatically.

One thing that would be good imho is to not break anything for existing users. (If there are any besides us...) So ideally, an existing user should not need to change anything on his side if he just switches from the current version to this newer one. (i.e. his/her scripts should continue to work unchanged.) That's also basically what I would test on my side. If you find the time and can give some feedback on how seamless it went for you, that would be great!

alexhartm commented 8 months ago

I finally came around trying this out on my raspberry as well. Works perfectly fine! Thanks a lot for your work! Will merge this and then do a pypi release later this weekend

alexhartm commented 8 months ago

@all-contributors please add @Wilhelmsson177 and @WilliMeierhofTT for ideas, code, test

allcontributors[bot] commented 8 months ago

@alexhartm

@Wilhelmsson177 already contributed before to ideas, code, test

alexhartm commented 8 months ago

@all-contributors please add @WilliMeierhofTT for ideas, code, test

allcontributors[bot] commented 8 months ago

@alexhartm

I've put up a pull request to add @WilliMeierhofTT! :tada: