search

alexhe / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

HTTPUpload::SendRequest should provide error code or error description to callers #221

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, HTTPUpload::SendRequest returns a boolean for success or
failure.  I'm trying to log failure reasons, and this isn't very helpful. 
I'd like to get an optional out param that returns the error code or a
description of the error.

Original issue reported on code.google.com by ted.mielczarek on 17 Oct 2007 at 2:28

GoogleCodeExporter commented 9 years ago 
This patch adds another out param for the error description.  libcurl uses an 
enum or
typedef or something for its error codes, and I didn't want to have to expose 
that in
the API here, so I settled for just returning the error string instead.

Original comment by ted.mielczarek on 2 Nov 2007 at 12:53

Attachments:

GoogleCodeExporter commented 9 years ago 
Checked in at r228.

Original comment by ted.mielczarek on 2 Nov 2007 at 12:23