search

alexhenning / wpi-suite-tng

Rewrite of the WPI Suite project management application
Other
5 stars 3 forks source link

Move the requirement buttons (i.e., Cancel, Complete!, Delete) to the requirement panel. #104

Closed tuna-salad closed 11 years ago

tuna-salad commented 11 years ago

Since we're going to have a reset button as well (#98), is it reasonable to move the buttons from the toolbar view directly into the requirement panel? Professor Pollice mentioned about the buttons being in the panel, rather than up there in the toolbar view, near the beginning of the term for other teams.

jbmorse commented 11 years ago

This should definitely be done.

WillSonOfWilliam commented 11 years ago

I've gotten the buttons onto the panel, but for some reason the text won't display on one of the buttons when you edit a requirement. and the text disappears on two of the buttons when you create a new requirement. The branch for this is dev-moveReqToolbarButtonsToPanel.

tncalvert commented 11 years ago

The text issue is most likely a result of using Actions as opposed to ActionListeners. Apparently buttons derive their text from an Action that is attached to them. If you switch over to an ActionListener (if possible) that should fix the problem, but you have to watch out because a button can have more than one ActionListener so make sure you remove any unwanted one prior to adding another.

tuna-salad commented 11 years ago

I made some recent changes about user interaction in RequirementToolbarView. I'm sure this file is going to be removed, so I recommend that you merge dev into this new branch (but not vice versa).

ctmanuel commented 11 years ago

All you need to do to fix the button problem is set the text after the action listeners are created. So its like "deleteButton.setText("Delete");". I would make the changes myself, but I'm having trouble pushing to this branch.