alexhenning / wpi-suite-tng

Rewrite of the WPI Suite project management application
Other
5 stars 3 forks source link

Build fails continuously from DummyServer #93

Closed tuna-salad closed 11 years ago

tuna-salad commented 11 years ago

It seems that Jenkins cannot find package edu.wpi.cs.wpisuitetng.network.dummyserver which refers to DummyServer used in our tests, even though every works fine on my local machine. Could this be because there is a dependency problem or the projects are not properly linked?

jpalnick commented 11 years ago
Your build has been broken (as far as Jenkins is concerned) for almost 24 hours.  You also
regressed tests on Tuesday and haven't fixed them.  You should fix these problems, because it
makes you look bad next to other teams with stable builds.  Leaving Jenkins to rot makes it
useless.

I believe the current build issue is from tests that Deniz added that use the DummyServer from
the Network project.  The build file in your project will need to be modified so that the
compiled DummyServer class from the Network project is on the classpath when you run tests.  Or,
if you want to be lazy and continue using a horrible technique, you can copy DummyServer and
dependencies into your project.  I was the one who introduced the DummyServer to Deniz (and
Sergey) so I probably should have mentioned that the build files will need to be tweaked.

Personally, I always compile and run tests from command line Ant before pushing to dev to make
sure I don't break the automated build like this.

- Andrew
tuna-salad commented 11 years ago

That didn't fix it.

tuna-salad commented 11 years ago

BUILD SUCCESSFUL!!!

tuna-salad commented 11 years ago

The problem seems to be because DummyServer resides in the test package of Network. Other projects that use the components of Network work just fine while our project is the only one to refer to this DummyServer, which is in the test folder. What I did was I added "../Network/build-test" in RM's build.xml. If this potentially causes other problems, please let everyone know it.

tuna-salad commented 11 years ago

Now, I have moved DummyServer from Network's test package into its source package (src) and undone the "build-test" above. The test-failure problem now seems to be caused by package "org/simpleframework/http/core/Container." I'll try to fix it by linking the library.

tuna-salad commented 11 years ago

The build (188) is now back to stable.