search

alexherbo2 / auto-pairs.kak

Auto-pairing of characters for Kakoune
https://kakoune.org
77 stars 18 forks source link

Revert auto-pairs-insert-new-line implementation to 5b4b3b7 #41

Closed johnisom closed 4 years ago

johnisom commented 4 years ago

Because I fixed mawww/kakoune#3617 with the merged PR mawww/kakoune#3620, my previous changes to this repo are no longer needed.

alexherbo2 commented 4 years ago

I prefer the current behavior you implemented; it looks better suited to auto-pairs.kak scope, to insert a new indented line in-between pair no matter what (e.g. plain text files, without indent rules). What do you think on that matter?

johnisom commented 4 years ago

After testing out my reverted version with a plaintext file, I have to agree with you. It's nice to have it indent even in files w/o indent rules. I also see the argument for keeping it regarding the scope of responsibility.

However, there is something nice about separation of responsibilities: filetypes takes care of indenting, auto-pairs takes care of pairing.

I don't have a strong opinion either way; I'll leave the decision up to you.