search

alexherbo2 / kakoune.cr

A command-line tool for Kakoune
https://kakoune.org
The Unlicense
54 stars 11 forks source link

do you mind if I fork this to add actions/releases? #8

Closed skewballfox closed 3 years ago

skewballfox commented 3 years ago

I wanted to learn more about deployment pipelines and the dev ops toolchain. I saw in this discussion that releases can be generated by github itself though github actions. I was wondering if you would be okay with this. if it works you could just merge it back into the main repository.

alexherbo2 commented 3 years ago

It could be nice to have them.

Currently, I use the following Dockerfile and script for static builds, and I have no experience either with GitHub Actions.

skewballfox commented 3 years ago

sweet, I forked it and added the crystal workflow to play around with, and cloned it. I should have something to within the next few days.

alexherbo2 commented 3 years ago

Added release.yml and updated the Installation section.

No support for macOS yet.

skewballfox commented 3 years ago

oh okay. I was a variation of the command from @vbauerster from the forum. I also wasn't using the makefile and using crystal directly though:

 - name: create release for mac
        run: crystal build --cross-compile --target "x86_64-apple-darwin20.3.0" --release -o kcr src/cli.cr

      - name: create release for rpi64
        run: crystal build --cross-compile --target "aarch64-unknown-linux-gnu" --release -o kcr src/cli.cr

I hadn't changed the ouput directory because I wasn't sure where the output was supposed to be stored, you can see the full github action (so far) here

skewballfox commented 3 years ago

I was only doing it on push, and only when given a semver tag, because I think on free accounts github limits your monthly run time for actions. I was planning on adding automatic versioning, so you could just push with some way of specifying "I want this push to be built"

skewballfox commented 3 years ago

on the macOS build, since after looking at the original post again I noticed it's not currently possible to cross compile for macOS, a possible workaround would be to get someone with a mac system to build it on their local system and publish that. doing so in an automated fashion seems like it would be rather hackish.

alexherbo2 commented 3 years ago

I’ve seen the use of a matrix in Install Crystal.

skewballfox commented 3 years ago

btw, should I quit working on this at this point? mainly trying to avoid double work.

alexherbo2 commented 3 years ago

As you wish. I learn the GitHub Actions as the same time as you. 😆

If you have nice solutions, I will gladly take them.

alexherbo2 commented 3 years ago

@skewballfox We have Linux and macOS releases now 🥳