search

alexherbo2 / krabby

A keyboard interface to the web, inspired by Kakoune
https://krabby.netlify.app
The Unlicense
311 stars 20 forks source link

Make installation instructions clearer #10

Closed micouy closed 4 years ago

micouy commented 4 years ago

Remove print_install_instructions after each step

I figured it isn't necessary. Printing it once at the end makes it more noticeable.

Add whitespace to make code more readable

If it doesn't suit you, I can remove it.

Make further instructions stand out

I added headers and confirmation after each header (if the script is being run in interactive mode).

image

That's how it looks like now.

Resolves #9.

alexherbo2 commented 4 years ago

You broke the script by redirecting to the wrong (just last) install path (dmenu).

Krabby is composed of multiple extensions, with different target paths, so you can’t print the install instructions just once (at least the way you did).