alexheretic / ab-av1

AV1 re-encoding using ffmpeg, svt-av1 & vmaf.
MIT License
442 stars 29 forks source link

Add `--keep` flag to `crf-search` subcommand #166

Closed t-nil closed 8 months ago

t-nil commented 9 months ago

For me it's very useful to look at the generated samples for manual verification. This command works on my machine right now.

@alexheretic please tell me if you want the flag refactored into args::Sample. Its probably better that way, right?

t-nil commented 9 months ago

Btw: what is the double purpose of cleaning in main() and sample_encode::run

alexheretic commented 9 months ago

Thanks, I 'm ok with crf-search & auto-encode having --keep. It does make we wonder if we should improve the output a bit though, e.g. informing which temp-dir is being kept so users don't have to guess / set one explicitly.

please tell me if you want the flag refactored into args::Sample. Its probably better that way, right?

Yes I think that makes sense.

Btw: what is the double purpose of cleaning in main() and sample_encode::run

Early cleaning keeps storage usage ceiling down. Cleaning at the end is required to handle ctrl-c interrupts & anything left over.

t-nil commented 8 months ago

Should be fine now :)

alexheretic commented 8 months ago

Looks good now, just one minor code comment.

Can you pop something in the changelog?

alexheretic commented 8 months ago

Thanks!