search

alexheretic / ab-av1

AV1 re-encoding using ffmpeg, svt-av1 & vmaf.
MIT License
483 stars 30 forks source link

Add wait to allow log file to be written #192

Closed whipstein closed 9 months ago

whipstein commented 9 months ago

This is a crude 1 second wait on completing the VMAF process. If this is not added, the option for requesting a logfile output from VMAF will not work. The process in killed before it has a chance to output the file.

alexheretic commented 9 months ago

Interesting thanks! I don't think I want sleeps in if I can help it, but this does narrow down the issue.

Can you try removing the kill_on_drop(true) from vmaf::run instead? :thinking: It probably won't be enough, but I'm thinking if we gracefully await the ffmpeg process ending it should solve this better.