alexheretic / ab-glyph

Rust API for loading, scaling, positioning and rasterizing OpenType font glyphs
Apache License 2.0
372 stars 24 forks source link

please include license text in published crates #23

Closed decathorpe closed 4 years ago

decathorpe commented 4 years ago

The ab_glyph and ab_glyph_rasterizer crates that get produced and uploaded to crates.io don't include the license text for your specified license - however, the Apache 2.0 license usually requires that you ship the text alongside the licensed material (see "License and Copyright notice" here).

Can you please include the license text in the published crates? If you're cargo publishing from linux/macos, adding a symlink LICENSE → ../LICENSE in both directories should be enough to accomplish this (since you're not excludeing anything in Cargo.toml).

EDIT: Forgot to actually link the thing I wanted to link to here.

alexheretic commented 4 years ago

I didn't think this was necessary, it's a bit annoying to have to copy the license to each subdirectory (git has no symlinks).

Do you have some references to other cargo workspace style projects that addressed this without license duplication?

decathorpe commented 4 years ago

git does support symlinks. For example, the futures crate does it this way: https://github.com/rust-lang/futures-rs/tree/master/futures-core

alexheretic commented 4 years ago

TIL, ok that sounds fine then, thanks for the example. I'll add the symlinks when I get a chance.

On Mon, 12 Oct 2020, 14:12 Fabio Valentini, notifications@github.com wrote:

git does support symlinks. For example, the futures crate does it this way: https://github.com/rust-lang/futures-rs/tree/master/futures-core

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alexheretic/ab-glyph/issues/23#issuecomment-707111555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARZHV4F4QGCV2JSQYOWLHLSKL6DPANCNFSM4SMO3AVQ .

decathorpe commented 4 years ago

Thanks!

alexheretic commented 4 years ago

Add the symlinks in c59c5ebd7ec053a3a9e944743a3d84a9d454a3a0