alexheretic / aurto

Arch Linux AUR tool for managing an auto-updating local 'aurto' package repository
MIT License
134 stars 9 forks source link

Add support for docker with README install instructions #88

Closed Ew4n1011 closed 1 year ago

Ew4n1011 commented 1 year ago

This is a push request that I submitted a couple of weeks ago, but then closed due to spotting a bug, which should now be resolved

This push requests adds a Dockerfile to add support for running aurto via a docker container, with included install instructions and a workflow to automatically build a new image every time a push is commited to the master branch and uploades it to the GitHub package registry.

Sidenote: the Dockerfile builds aurto from the AUR, which may make it slightly behind github commits at times.

alexheretic commented 1 year ago

Thanks for raising this! This seems useful, allowing running aurto from another distro.

Some thoughts:

Ew4n1011 commented 1 year ago

Thanks for the feedback! I took a look at what you said above on your previous comments and tried to apply them. Most of them are mentioned in their own convos but regarding what you had in the bullet section of your message above:

Also I tried to minimise the image as much as possible by removing cache and whatnot, but the least I could manage was 1.49 GB (maybe you have an idea on how to decrease it further?)

alexheretic commented 1 year ago

That sounds great thanks! I'll re-review a little later when I have more free time.

AladW commented 1 year ago

The docker image size is fairly large (1.7GB vs archlinux 432MB). This could maybe be reduced by having a 2-stage build (makepkg aurto/aurutils and copy them to final image) & perhaps removing more cache stuff.

This might be due to depending on devtools, which pulls in python etc.

Ew4n1011 commented 1 year ago

~Ah I see, maybe possible to minimise if it only pulls needed packages instead of all base-devel?~

Just learnt that devtools is actually its own package, so since it needs it, there's no other way to minimise space right?

AladW commented 1 year ago

It doesn't need it if you disable chroot builds

Ew4n1011 commented 1 year ago

Ah ok, I did disable it for aurto but guessing it's a different way for aurutils? I'll have a look at that later

alexheretic commented 1 year ago

Ah ok, I did disable it for aurto but guessing it's a different way for aurutils? I'll have a look at that later

devtools is a required dependency of aurto right now, so my bad. We can improve this later

alexheretic commented 1 year ago

Great stuff @Ew4n1011 thank you!