alexhernandezgarcia / gflownet

Generative Flow Networks - GFlowNet
https://gflownet.readthedocs.io/en/latest/
Apache License 2.0
167 stars 11 forks source link

min and norm properties of proxies can lead to silent errors #243

Open alexhernandezgarcia opened 11 months ago

alexhernandezgarcia commented 11 months ago

So if the caller of that property (accidently) does anything inplace on the returned tensor, that change will affect everyone else calling min in the future? If so, it feels like it might lead to bugs that would be really difficult to track. Same comment applies to the other proxies that implement the same strategy : torus (for min and norm) and uniform (for min).

_Originally posted by @carriepl in https://github.com/alexhernandezgarcia/gflownet/pull/204#discussion_r1339104632_