search

alexhillc / AXPhotoViewer

An iOS/tvOS photo gallery viewer, useful for viewing a large (or small!) number of photos.
https://www.cocoacontrols.com/controls/axphotoviewer
MIT License
646 stars 119 forks source link

Crash on animated dismmissing controller. #28

Closed ndarmancev closed 5 years ago

ndarmancev commented 6 years ago

Lib version: AXPhotoViewer (1.3.6) AXStateButton (1.1.4)

crash at line 226 at file AXPhotosTransitionController

photosViewController.currentPhotoViewController at the moment of dismiss have nil value,

guard let imageView = photosViewController.currentPhotoViewController?.zoomingImageView.imageView as UIImageView? else { assertionFailure("No. ಠ_ಠ") return }

P.S. It so funny and so "professional" have this smiles instead description text inside crash log?

alexhillc commented 6 years ago

Hey bud, sorry you're having issues. Those assertions are there because they should never happen. I can take a look at the root cause of this problem, but I would advise against assuming professionalism on Github. A lot of people (such as myself) make libraries like this because we are bored, and find uses for it in other projects that we work on.

ndarmancev commented 6 years ago

Good day Alex, thank you for this library. I understood, but at least this comments looks really strange.