search

alexhillc / AXPhotoViewer

An iOS/tvOS photo gallery viewer, useful for viewing a large (or small!) number of photos.
https://www.cocoacontrols.com/controls/axphotoviewer
MIT License
646 stars 119 forks source link

Customising the actionBarButtonItem and closeBarButtonItem via subclassing the PhotosViewController #6

Closed deepmode closed 7 years ago

deepmode commented 7 years ago

I was trying to override the actionBarButtonItem and closeBarButtonItem (just for the look and feel) via subclassing the PhotosViewController. The Swift compiler have this warning "Overriding non-open var outside of its defining module". To get this working, I have to change the method declaration from public to open. I wonder if this the only option for just changing the look and feel.

alexhillc commented 7 years ago

Hi @deepmode, thanks for the report. All exposed overrideable variables should have the ‘open’ qualifier. If they don’t, it’s a mistake on my part. I can fix this later today and push out a new release.

alexhillc commented 7 years ago

Fixed in: 51073b36564813b96dd275a56241bbf629c0f156

deepmode commented 7 years ago

Thanks!