search

alexhillc / AXPhotoViewer

An iOS/tvOS photo gallery viewer, useful for viewing a large (or small!) number of photos.
https://www.cocoacontrols.com/controls/axphotoviewer
MIT License
646 stars 119 forks source link

Moving resources to resource bundle #82

Open OneSman7 opened 3 years ago

OneSman7 commented 3 years ago

Hello @justindhill! You wrote that you still come here from time to time to maintain the repository. This is a wonderful and simple library with many ready-to-go integrations that we are to this day using in our app.

We want to optimise our pod installation process: at the times of Xcode 10 we had to add :disable_input_output_paths => true to Podfile to mitigate CocoaPods/CocoaPods#8122. These days we found that every other pod moved to using resources_bundle except this one. I wrote a simple PR ( #81 ) to fix this. It would be cool if you could merge it and add version 1.7.2 tag to the master branch.

Thank you in advance!

justindhill commented 3 years ago

Hi @OneSman7, I'll try to have a look at this tonight and get it merged. Thanks for the PR!

OneSman7 commented 3 years ago

hello again! any news?

OneSman7 commented 3 years ago

@justindhill also edited FLAnimatedImage module import to support the latest version in PR