alexhua / Aria2-Explorer

An aria2 download task management extension for chromium based browser
https://www.aria2e.com/
BSD 3-Clause "New" or "Revised" License
789 stars 66 forks source link

Added option for custom rules #31

Closed harshithmohan closed 4 years ago

harshithmohan commented 4 years ago

Screenshot_20200501_203626

alexhua commented 4 years ago

Hi Harshith,

Appreciate your PR. It is a good idea to manage multi Aria2c RPC. After careful review, I have some advice. 80815520-71244800-8beb-11ea-9e2b-28b9a169a41f Whould you like you to revise the UI like above pic that is one RPC URL followed one URL pattern.

According to your code, only one URL will be selected by rule at the end, the top URL will be the default. So I think this UI style is more simplicity and intuitive. And also if the users want to change the default URL, they could just add " * " to that URL's rule. This feature could just meet the user's demand of changing default URL. If modified, the code will be more refined.

Waiting for you response. Thanks

harshithmohan commented 4 years ago

I hadn't thought of that. Thank you. This is how I made it now. Some people may have multiple patterns, so they can use them separated by a comma. Is this good? Screenshot_20200509_210134

alexhua commented 4 years ago

Yes, it is what i mean. I've added a new feature and some comments for you. Would you please raise a new pull request based on the latest code? Thanks

harshithmohan commented 4 years ago

I've made the new PR, you can close this one

alexhua commented 4 years ago

raised a new one #32