alexhude / FRIEND

Flexible Register/Instruction Extender aNd Documentation
545 stars 70 forks source link

Fix string handler for two level strings #12

Closed pedrib closed 7 years ago

pedrib commented 7 years ago

This fixes the string summary when a string is nested two levels deep. For example, a string might be referenced in a function: 00009384 010 LDR R2, =aBinSystemctlIs ; "/bin/systemctl is-active %s

But then this actually points to .text:0000941C C8 C5 00 00 off_941C DCD aBinSystemctlIs ; DATA XREF: systemctl_check_daemon_active+Cr

which then points to the real string: .rodata:0000C5C8 2F 62 69 6E+ aBinSystemctlIs DCB "/bin/systemctl is-active %s",0

Now the plugin correctly handles these strings and displays them in the function summary.

alexhude commented 7 years ago

Good catch! Thanks.