Linux and Windows port - Githubissues

alexhude / FRIEND

Flexible Register/Instruction Extender aNd Documentation

545 stars 70 forks source link

Linux and Windows port #6

Closed kamino closed 7 years ago

kamino commented 7 years ago

This pull request brings the following features:

support for other platforms than MacOS (namely, Windows and Linux). It uses cmake to compile everything easily from the CLI and to generate project for Xcode or Visual Studio.
updated Readme.md with build instruction for each platform.
removes static libraries: capstone-engine and pugixml are build from their respective mainlines. Removing static AEXML.framework for HintEditor is going to land in another PR.

Any feedbacks are appreciated.

alexhude commented 7 years ago

Thanks for PR. Checked briefly - looks very good. I am currently working on some new cool features for FRIEND but will definitely review your changes when I have time.

kamino commented 7 years ago

Hey @alexhude ! Thank you for your feedbacks. Can you push your modifications on top of this PR ? I'll check that everything compiles on Windows and Linux and we'll be ready to merge it.

alexhude commented 7 years ago

OK, sounds like a plan. I will merge this PR, apply my changes, test it on Mac, then you can test on Win/Linux.

kamino commented 7 years ago

An alternative workflow is to create a branch on your repository with my PR and your modifications. I'll update my PR to target this new branch. I will not have to open a new PR if there are more modifications.

kamino commented 7 years ago

Just to let you know, it compiles and run on Windows and Linux. Thanks !

alexhude commented 7 years ago

Awesome, thanks! And 386c3fcb566789f0c59b5067e483e1345547e31d finally fixes Xcode project.