aleximmer / Laplace

Laplace approximations for Deep Learning.
https://aleximmer.github.io/Laplace
MIT License
432 stars 61 forks source link

Remove default `loss` for `optimize_prior_precision` #156

Closed runame closed 2 months ago

runame commented 3 months ago

When using method=gridsearch the user is supposed to specify a loss which will be used to evaluate the performance. Currently loss defaults to a classification loss, independent of the likelihood used for the Laplace approximation itself. I suggest to not set any default and raise an informative error if gridsearch is selected without specifying a loss. Alternatively, we could choose the default based on likelihood.