search

aleximmer / Laplace

Laplace approximations for Deep Learning.
https://aleximmer.github.io/Laplace
MIT License
432 stars 61 forks source link

FeatureExtractor and Python <3.11 #195

Closed Ludvins closed 3 weeks ago

Ludvins commented 3 weeks ago

With the latest update, the FeatureExtractor class requires Python >= 3.11 due to *([0] * n_intermediate_dims) link. This raises an InvalidSyntax error due to "Unpack operator in subscript requires Python 3.11 or newer" if using Python 3.10 for example.

wiseodd commented 3 weeks ago

Interesting, I always assumed that it works in all cases. I personally uses Python 3.12 for the pattern matching and the Rust-like compiler error messages.

Will work fix this.

[!NOTE] At a glance, the fix seems easy---just remove that unpack operator *.

In any case, this shouldn't happen again when the Github actions in https://github.com/aleximmer/Laplace/pull/176 are deployed (checked agains Python 3.9).