alexis-mignon / python-flickr-api

A python implementation of the Flickr API
BSD 3-Clause "New" or "Revised" License
367 stars 108 forks source link

async is a reserved word in python 3.7 and shouldn't be used as a keyword argument #105

Closed phdesign closed 5 years ago

phdesign commented 5 years ago

upload.py accepts a keyword argument async, however this is now a reserved word in python 3. Suggest renaming it to asynchronous.

phdesign commented 5 years ago

FYI, a temporary workaround is to unpack a dict of keyword arguments:

flickr_api.upload(**{
    "photo_file": "path_to_the_photo_file",
    "title": "My title",
    "async": 1})
mtrovo commented 5 years ago

I added the option to provide a parameter asynchronous as a alias of async.

I released it on a new version so please make sure to update your dependency and test it again.