Save adds extensions even when provided

alexis-mignon / python-flickr-api

A python implementation of the Flickr API

BSD 3-Clause "New" or "Revised" License

367 stars 108 forks source link

Save adds extensions even when provided #109

Closed mtrovo closed 5 years ago

mtrovo commented 5 years ago

Save API changed in an incompatible way as pointed here beaufour/flickr-download#48.

There are valid reasons to provide a whole filename instead of just the name part and we should support it.

Right now I think the best solution should be:

when an extension is provided, use it.
when no extension is provided, use the default one based on the source page.

Examples:

when source is 1234.jpg, calling save('abcd.jpg') will create file abcd.jpg
when source is 1234.jpg, calling save('abcd.mp4') will create file abcd.mp4
when source is 1234.jpg, calling save('abcd') will create file abcd.jpg

beaufour commented 4 years ago

@alexis-mignon / @mtrovo any chance for a new release that includes this? I'm depending on the fix for my project.

beaufour commented 4 years ago

Any chance of a new release with this fix in it?

alexis-mignon commented 4 years ago

@beaufour Would you like to become maintainer on this projet ? Since I don't have much time to take care of it ?

beaufour commented 4 years ago

@beaufour Would you like to become maintainer on this projet ? Since I don't have much time to take care of it ?

It's nice of you to ask, but I can't say I have a ton of time either so I think it would be "false advertising" if I were to pretend to be a maintainer... it depends on how busy the project is I guess? If it's only the odd request now and again I guess I could do it.

alexis-mignon commented 4 years ago

It's usually only a few requests every now and then indeed. Usually accepting some pull requests and uploading a new version once a few have been accepted.

And it's much better if maintainers actively use the project which is unfortunately not my case anymore. This means it rakes me even more time to get back into it when I need to. So it would really be a pleasure.

If you can indicate me an Id on PyPi I can register you as a maintener there too, so you can release new versions.

beaufour commented 4 years ago

Ok. Let's try then :) I'm "beaufour" on PyPi