search

alexis-mignon / python-flickr-api

A python implementation of the Flickr API
BSD 3-Clause "New" or "Revised" License
367 stars 108 forks source link

convert bytes to string before json parsing for python 3 support - cl… #112

Closed duhaime closed 5 years ago

duhaime commented 5 years ago

…oses #111

duhaime commented 5 years ago

it looks like this one method handles all json parsing for the app (nice factoring!), so this should take care of python 3 users...

mtrovo commented 5 years ago

Hey, thanks for the PR, I think it's better to solve this problem by using resp.json() from requests directly. Would you mind updating your PR to handle it this way?

duhaime commented 5 years ago

@mtrovo sounds good!

I also added a test for bytes responses, and took a moment to update some method calls in the extant tests that were throwing deprecated method warnings.

duhaime commented 5 years ago

@mtrovo just checking in to see if you saw these changes!

duhaime commented 5 years ago

ping @mtrovo ping @alexis-mignon

duhaime commented 5 years ago

I just pinged both of you as the library blows up in Python 3 without this change, and Python 2 is now largely defunct...

duhaime commented 5 years ago

@alexis-mignon Merci!