Fix a library-breaking configuration issue for Cocoapods

alexisakers / HTMLString

Escape and unescape HTML entities in Swift

MIT License

170 stars 69 forks source link

Fix a library-breaking configuration issue for Cocoapods #19

Closed DaemonF closed 4 years ago

DaemonF commented 5 years ago

@alexaubry: This podspec as written depends on a git tag for version 5.0.0 which doesn't exist.

The plist file containing all of the entity mappings was not included as a source file in the Podspec, so it does not exist when this library is used via Cocoapods. The error handling logic silently fails by using an empty unescapingTable and this results in the library failing to unescape strings.

The silent failure should probably be addressed, but for this PR, I'm just going to fix the issue.

DaemonF commented 5 years ago

@alexaubry, from what I can see, the tagged 5.0 version still has this issue. The breakage is silent and users may not be aware.

alexisakers commented 4 years ago

Hi there, sorry for the long delay responding to your PR. There is no longer a plist file for the mappings so this should no longer be an issue.