search

alexisakers / HTMLString

Escape and unescape HTML entities in Swift
MIT License
170 stars 69 forks source link

Infinite recursive calls + Objective-C test suite #32

Closed JCSooHwanCho closed 4 years ago

JCSooHwanCho commented 4 years ago

Hi again, @alexaubry Unfortunately, the previous update causes a critical issue (#31). So I patched it.(It looks same, but makes different consequence) And I felt that we need a objective-c test suite. Current test suite is only swift, current code passes it, but has some problem in objective-c context. So I added it using XCTest.

I wanted to add test automation for objective-c test suite, but I failed to achieve yet. And I wanted to share Test Data both in Swift and Objective-c, but header generating in test target doesn't work as expected.

The most interesting is that the performances of pure swift String and objective-c bridged String are significantly different. You'd better try it.

JCSooHwanCho commented 4 years ago

Maybe I can find a better setting for test. I'll make pull request again.