alexiscn / MetalFilters

Instagram filters implemented in Metal
https://github.com/alexiscn/MetalFilters
MIT License
363 stars 50 forks source link

Crash since iOS 13.3.1 #4

Closed mariusvirus closed 4 years ago

mariusvirus commented 4 years ago

This issue happens on the Demo app because some resources cannot be loaded.

Crashed here "Fatal error: Unexpectedly found nil while unwrapping an Optional value"

crash

I just found out that the problem is somewhere in metal file, for example "MTHudsonFragment" in MTHudsonFilter.metal. I do not know what the problem is exactly. Thank you!

alexiscn commented 4 years ago

It seems that we can not init CIImage with PVR format texture in iOS 13.3.1.

I have change to load texture with MTLTextureLoader and seems to fixed that crash.

mariusvirus commented 4 years ago

Everything look fine now and it is working as is should. Thank you and can you please guide me to some tutorial of kernel or how can I make my own custom filters?