search

alexiscreuzot / KASlideShow

Ultra-basic slideshow for iOS (ARC only).
MIT License
206 stars 61 forks source link

Support For URL Loading #38

Closed glennposadas closed 8 years ago

glennposadas commented 8 years ago

I found this repo on Github that has this enhancement feature for KASlideShow: https://github.com/ad4n/KASlideShow-SDWebImage If you could merge this functionality, it will be so great!

alexiscreuzot commented 8 years ago

Nice find, I think this would be nice as a subspec as I'd prefer for the library not to rely on too many dependencies. I'll look into it.

glennposadas commented 8 years ago

Actually @kirualex , the KASlideShow+SDWebImage I found and posted above works perfectly fine. I really love it, it has a caching feature and everything I need for my project. What I am asking you is, it would be great if it is possible for you to merge that ad4n's work into your work since you're already supporting cocoapods. I'm just wondering though why that guy didn't file a pull request. Anyway, thank you so much for this open source library.

G

alexiscreuzot commented 8 years ago

The issue is that I don't want KASlideShow pod to automatically download SDWebImage, as many people only use local images and may not appreciate having unnecessary dependencies. A subspec would make more sense, I'll have a look when I have time.

samiq commented 8 years ago

any update on this? I'd find it interesting how many people use this with local images vs web, as I'm sure most apps these days are dynamic and use content from the web in the great majority of cases. love the component by the way, it's just happens to add more work to keep the functionalities separate

alexiscreuzot commented 8 years ago

Implemented in 3.0.0

samiq commented 8 years ago

@kirualex thanks :)

glennposadas commented 8 years ago

Hot damn. Thank you so much. Now i dont need to re attach sdwebimage to my pods everytime I do pod install or pod update.

Glenn On Jul 25, 2016 6:22 PM, "Alexis Creuzot" notifications@github.com wrote:

Closed #38 https://github.com/kirualex/KASlideShow/issues/38.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kirualex/KASlideShow/issues/38#event-733336694, or mute the thread https://github.com/notifications/unsubscribe-auth/AL7GlzsHnWOCPNpd_NxU2r_DHe68nov8ks5qZI50gaJpZM4JBsbG .