search

alexislours / ACNHAPI

Data in JSON format from https://acnhapi.com
MIT License
224 stars 71 forks source link

Images are spaced around inconsistently (for fish anyways) #17

Open CephNightmare opened 4 years ago

CephNightmare commented 4 years ago

Hi,

First of all, thanks for making this API publicly available!

I have a problem with the spacing around the images of the animal. Is it at all possible to either:

  1. Trim the images so the spacing isn't an issue when sizing the image
  2. As an alternative, at least centering the animal properly. The crucian carp for example isn't centered, so centering in a layout is impossible.

Any help or advice would be greatly appreciated!

alexislours commented 4 years ago

The images are as found in the game files and these endpoint will most likely remain as such. I might add an endpoint down the line with cropped version of these images.

CephNightmare commented 4 years ago

That would be a great addition! There seems to be an easy way to crop the images using a package: https://www.npmjs.com/package/trim-image

Maybe this would be useful to run for the existing dataset when you intend to look at it?

alexislours commented 4 years ago

I already have the cropped images. For every images there is in the game. But thanks for the suggestion. The trouble is more finding the time between work to update the data, add the endpoint and update the doc.

CephNightmare commented 4 years ago

Fair enough, i'd be willing to help out if you'd like?