Add house_uri for each villager

alexislours / ACNHAPI

Data in JSON format from https://acnhapi.com

MIT License

224 stars 71 forks source link

Closed Corentints closed 4 years ago

Corentints commented 4 years ago

Hey, I needed each villager's house for a project, so I added them to the JSON. I thought it might be cool to share it with everyone 👍

alexislours commented 4 years ago

I won't validate this merge for a few reasons. It's not that I don't like the idea but:

URIs are pointing to acnhcdn.com while these images are also hosted on acnhapi.com, under the same path. This would make the dataset rely partly on a third party that is out of my control.
If I were to add the images, I would rather also add an endpoint for them, so people can request them with the villager ID.

I'll look into integrating it in the coming days.

Corentints commented 4 years ago

Oh, I didn't know the images were also available on your domain, sorry!